|
From: Mark W. <ma...@kl...> - 2023-04-20 13:19:35
|
Hi Sasha,
On Thu, 2023-04-20 at 15:01 +0200, Mark Wielaard wrote:
> Looks like this was in response to Philippe's review. Thanks.
> I added one more comment at the top describing the three usages of
> vgdb. And fixed up a few places where tabs were used for indentation
> (we are not very consistent in that either, after the release we'll
> look into adopting something like clang-format so you don't have to do
> all this by hand). And a missing newline in coregrind/m_main.c to make
> none/tests/cmdline2 pass.
>
> Pushed with the following commit message to show what was changed:
And then I messed up and didn't include those small fixups I described,
sorry. Pushed a followup commit:
Author: Mark Wielaard <ma...@kl...>
Date: Thu Apr 20 15:04:03 2023 +0200
vgdb --multi: fix various typos, indentation and such (followup)
commit 56ccb1e36c4722b56e3e602b986bc45025cb685d missed a few small
fixlets:
- one more comment at the top describing the three usages of vgdb.
- fixed up a few places where tabs were used for indentation (we are
not very consistent in that either, after the release we'll look
into adopting something like clang-format so you don't have to do
all this by hand).
- Add a missing newline in coregrind/m_main.c to make
none/tests/cmdline2 pass.
Sorry for messing this up. One day git and I will become friends...
Cheers,
Mark
|