|
From: Mark W. <ma...@kl...> - 2023-04-20 13:02:11
|
Hi Sasha,
Looks like this was in response to Philippe's review. Thanks.
I added one more comment at the top describing the three usages of
vgdb. And fixed up a few places where tabs were used for indentation
(we are not very consistent in that either, after the release we'll
look into adopting something like clang-format so you don't have to do
all this by hand). And a missing newline in coregrind/m_main.c to make
none/tests/cmdline2 pass.
Pushed with the following commit message to show what was changed:
commit a32e26dd072a82aacafcdd22bd7c94c7b4d2afcc
Author: Alexandra Hájková <aha...@re...>
Date: Thu Apr 20 14:17:29 2023 +0200
vgdb --multi: fix various typos, indentation and such
Remove --launched-with-multi from --help-debug output since it is not
a real user option. Do add a comment in m_main.c explaining the
internal usage.
Add a top-level comment describing the three usages of vgdb.
Fix comment description of decode_hexstring, create_packet,
split_hexdecode.
Consistently use 3 space indention in send_packet and receive_packet
and next_delim_string and split_hexdecode, count_delims,
do_multi_mode.
Fix return type of count_delims to size_t.
Add a note in coregrind/m_gdbserver/server.c to sync qSupported
replies with coregrind/vgdb.c.
Use vgdb (all lowercase) and GDB (all caps) consistently in the
manual.
Thanks,
Mark
|