|
From: Nicholas N. <n.n...@gm...> - 2023-04-18 05:05:48
|
On Tue, 18 Apr 2023 at 13:41, Eyal Soha <eya...@gm...> wrote: > The problem with doing this is that it really messes with the git blame, > introducing a lot of changes! > That's always the first objection that is raised. Turns out there's a good solution <https://medium.com/codex/how-to-introduce-a-code-formatter-without-messing-up-git-history-4a16bd074c10> . > If you do this, you should probably add some sort of formatting check to a > CI process somewhere, otherwise your work will get stale and you'll just be > doing the clang-format again in a year from now. > Yes. > Good luck to you trying to get everyone to agree on a format! Ha! > It requires negotiation, but it's doable. Remember, all of this was done successfully for Firefox, which is a much bigger and gnarlier codebase than Valgrind. Nick |