|
From: Floyd, P. <pj...@wa...> - 2023-03-24 10:39:14
|
On 23/03/2023 11:51, Nicholas Nethercote wrote: > > This requires that all the tests pass before merging a change. Having > worked on projects that follow this and projects that don't, I say > with confidence that it's a good idea. If we could get that happening > for Valgrind, that alone would be a huge improvement over the status > quo. I looked at the sites you linked, but couldn't work out much > about how they work. CI tests are good, as long as they aren't too slow or flaky - we do have the occasional test that fails intermittently, but no huge muti-day tests. The problem I see is for the 'other' platforms that CI probably won't cover: x86, FreeBSD, Solaris, macOS. Manually testing on all those is tedious which can result in a bit of git ping-pong to get things like expected filters to converge on working on all platforms. > Mozilla's been using clang-format for Firefox C and C++ code for > several years. I'd be happy to have anything like K&R or Allman formatting - not keen on GNU style. I really do appreciate being able to grep for patterns like "variable = " knowing that there will always be just one space to find all assignments without having to wrestle with RE whitespaces or wade through all uses of 'variable'. And I presume that this can be done with a git hook. A+ Paul |