|
From: Nicholas N. <n.n...@gm...> - 2023-03-23 10:51:44
|
On Thu, 23 Mar 2023 at 20:15, Mark Wielaard <ma...@kl...> wrote: > > Modulo using github these sound like interesting ideas. Forcing this > workflow might be a bit heavy weight. But we could use sourceware > try-branches so all commits go through the CI builders. Requiring all > passing builds will be a bit of a puzzle since out testsuite(s) aren't > zero-fail. > I threw a lot of ideas out in my earlier email, but this is the most important one. Graydon Hoare expressed <https://graydon2.dreamwidth.org/1597.html> this years ago as: *The Not Rocket Science Rule Of Software Engineering:* > automatically maintain a repository of code that always passes all the > tests > This requires that all the tests pass before merging a change. Having worked on projects that follow this and projects that don't, I say with confidence that it's a good idea. If we could get that happening for Valgrind, that alone would be a huge improvement over the status quo. I looked at the sites you linked, but couldn't work out much about how they work. W.r.t. failing tests, this would give great incentive to fix currently failing tests (or disable them if they cannot be made reliable) and to keep them passing. Sourceware builder could help with that, we can setup a CI bot that > runs such a formatter over all commits to check formatting. I have > seen that work very nicely with the python black formatter. But for C > code/clang-format it seems the formatter seems not that good/stable. > Mozilla's been using clang-format for Firefox C and C++ code for several years. Nick |