Re: [Valgrind-testresults] Buildbot failure in Wildebeest Builder on whole buildset

[Mark W. <ma...@kl...>]

Hi,

The buildbot found two setups where the make distcheck test failed with
the last commit:

On Sat, 2021-02-20 at 17:25 +0000, bui...@bu...
wrote:
> The Buildbot has detected a failed build on builder whole buildset
> while building valgrind.
> Full details are available at:
>     https://builder.wildebeest.org/buildbot/#builders/37/builds/143
> 
> Buildbot URL: https://builder.wildebeest.org/buildbot/
> 
> Worker for this Build: fedora-x86_64
> 
> Build Reason: <unknown>
> Blamelist: Bart Van Assche <bva...@ac...>
> 
> BUILD FAILED: failed test (failure)
> 
> Sincerely,
>  -The BuildbotThe Buildbot has detected a failed build on builder
> whole buildset while building valgrind.
> Full details are available at:
>     https://builder.wildebeest.org/buildbot/#builders/38/builds/122
> 
> Buildbot URL: https://builder.wildebeest.org/buildbot/
> 
> Worker for this Build: fedora-s390x
> 
> Build Reason: <unknown>
> Blamelist: Bart Van Assche <bva...@ac...>
> 
> BUILD FAILED: failed test (failure)

Should hopefully be fixed by:

commit 7aac53c6d0ca7e11d4037ff474dcd1c08862fd30
Author: Mark Wielaard <ma...@kl...>
Date:   Sat Feb 20 20:05:31 2021 +0100

    Fix valgrind.h include in drd/tests/swapcontext.c
    
    In tree tests should include "valgrind.h" not <valgrind/valgrind.h>
    the later might pick up the system installed valgrind.h and doesn't
    work when srcdir != builddir.

diff --git a/drd/tests/swapcontext.c b/drd/tests/swapcontext.c
index e73a612dc..f3944d1ba 100644
--- a/drd/tests/swapcontext.c
+++ b/drd/tests/swapcontext.c
@@ -11,7 +11,7 @@
 #include <sys/timerfd.h>
 #include <ucontext.h>
 #include <unistd.h>
-#include <valgrind/valgrind.h>
+#include "valgrind.h"
 
 typedef struct thread_local {
   ucontext_t uc[3];

If not, I am sure the buildbot will let us know soon :)

Cheers,

Mrk