|
From: Ross M. <ros...@ie...> - 2020-04-27 13:11:07
|
You're undoubtedly correct, Paul, about config.h. I didn't make any changes to it though. You can discard changes to it if you wish. config.h was apparently in the original distribution, and was changed automatically when I built valgrind, so it got caught up in the diff. I'm guessing it probably shouldn't be in the distribution at all, if it's automatically rebuilt? I thought about editing it out of the diff, but opted not to, since I assumed it didn't matter -- those changes would be lost anyway when someone else reconfigured and rebuilt. Ross On Sun, Apr 26, 2020, 11:03 PM Paul Floyd <pj...@wa...> wrote: > > > > On 26 Apr 2020, at 23:03, Ross Martin <ros...@ie...> wrote: > > > > I use valgrind quite a bit; unfortunately it didn’t support some of the > ioctl’s I’m using for my current project. Here’s the patch. > > > > > > diff -ruw valgrind-3.15.0-orig/config.h valgrind-3.15.0/config.h > > --- valgrind-3.15.0-orig/config.h 2019-04-13 03:57:38.000000000 -0700 > > +++ valgrind-3.15.0/config.h 2020-04-24 19:05:10.315888225 -0700 > > @@ -60,7 +60,7 @@ > > #define HAVE_ASM_UNISTD_H 1 > > > > /* Define to 1 if as supports fxsave64/fxrstor64. */ > > -#define HAVE_AS_AMD64_FXSAVE64 1 > > +/* #undef HAVE_AS_AMD64_FXSAVE64 */ > > > Hi Ross > > I think that the changes to config.h should really be in config.h.in and > configure.ac > > A+ > Paul > > _______________________________________________ > Valgrind-developers mailing list > Val...@li... > https://lists.sourceforge.net/lists/listinfo/valgrind-developers > |