|
From: Mark W. <ma...@so...> - 2019-05-15 22:19:27
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=c212b72a63e43be323a4e028bbdbe8b023c22be8 commit c212b72a63e43be323a4e028bbdbe8b023c22be8 Author: Mark Wielaard <ma...@kl...> Date: Wed May 15 21:30:00 2019 +0200 Explicitly make testcase variable for sys-copy_file_range undefined. On some systems an extra warning could occur when a variable in the memcheck/tests/linux/sys-copy_file_range testcase was undefined, but (accidentially) pointed to known bad memory. Fix by defining the variable as 0, but then marking it explicitly undefined using memcheck VALGRIND_MAKE_MEM_UNDEFINED. Followup for https://bugs.kde.org/show_bug.cgi?id=407218 Diff: --- memcheck/tests/linux/sys-copy_file_range.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/memcheck/tests/linux/sys-copy_file_range.c b/memcheck/tests/linux/sys-copy_file_range.c index 83981c6..589399c 100644 --- a/memcheck/tests/linux/sys-copy_file_range.c +++ b/memcheck/tests/linux/sys-copy_file_range.c @@ -3,8 +3,8 @@ #include <stdio.h> #include <stdlib.h> #include <sys/stat.h> -#include <sys/syscall.h> #include <unistd.h> +#include "../../memcheck.h" int main(int argc, char **argv) { @@ -51,7 +51,7 @@ int main(int argc, char **argv) /* Check valgrind will produce expected warnings for the various wrong arguments. */ do { - void *t; + void *t = 0; VALGRIND_MAKE_MEM_UNDEFINED (&t, sizeof (void *)); void *z = (void *) -1; ret = copy_file_range(fd_in, t, fd_out, NULL, len, 0); |