|
From: Bart V. A. <bva...@ac...> - 2018-12-03 19:35:27
|
On Mon, 2018-12-03 at 20:11 +0100, Andreas Arnez wrote:
> On Sat, Dec 01 2018, Bart Van Assche wrote:
> > On 11/21/18 8:47 AM, Andreas Arnez wrote:
> > > diff --git a/coregrind/m_demangle/demangle.c b/coregrind/m_demangle/demangle.c
> > > index 00fa20389..dd933da8b 100644
> > > --- a/coregrind/m_demangle/demangle.c
> > > +++ b/coregrind/m_demangle/demangle.c
> > > @@ -1,3 +1,4 @@
> > > +/* -*- mode: C; buffer-read-only: nil -*- */
> > > /*--------------------------------------------------------------------*/
> > > /*--- Demangling of C++ mangled names. demangle.c ---*/
> > > diff --git a/coregrind/m_demangle/vg_libciface.h b/coregrind/m_demangle/vg_libciface.h
> > > index 762e63a02..1aefd5db3 100644
> > > --- a/coregrind/m_demangle/vg_libciface.h
> > > +++ b/coregrind/m_demangle/vg_libciface.h
> > > @@ -1,3 +1,4 @@
> > > +/* -*- mode: C; buffer-read-only: nil -*- */
> >
> > Can this be left out? I'd like to avoid mode lines in source files.
>
> Not sure. Do you know another way to exempt these files from being
> marked read-only?
Are these modelines necessary since your patch adds the following to
.dir-locals.el?
+ ("coregrind/m_demangle"
+ ;; Most files in this directory should not be edited; they are imported
+ ;; from libiberty through the auxprogs/update-demangler script.
+ . ((nil . ((buffer-read-only . t))))
+ )
> > How about Helgrind? Are files in helgrind/tests indented by 2 or by 3
> > columns? Is a similar file needed in helgrind/tests?
>
> The C source files in that directory use various different indentation
> widths, sometimes even within the same file. I haven't measured which
> of these occurs most often, but it's certainly not obvious. So maybe we
> could just as well postulate that these files should converge to
> Valgrind's usual style. What do you think?
That sounds fine to me. But since Julian is maintaining Helgrind, Julian
has the last word about Helgrind test indentation.
Bart.
|