|
From: Mark W. <ma...@kl...> - 2018-11-06 08:46:18
|
On Mon, 2018-11-05 at 22:07 +0100, Philippe Waroquiers wrote: > On Mon, 2018-11-05 at 13:24 +1100, Nicholas Nethercote wrote: > > Why'd you do that? This file's style is now less like the style used throughout most of this codebase and most other C/C++ codebases. > > Humph, it looks like I was recently too much working on GDB, that follows > the GNU coding style which mandates 'function (arg' (this is also > used > at my work). Yes, I like GNU style most since that is more consistent with almost every other code base I work on. > But effectively, doing some grep on the valgrind code basis, we have > various different styles such as > 'function(arg' > 'function (arg' > 'function ( arg' > 'function( arg' > > but it looks like valgrind uses more the first style than the 3 > others. > So, I will rather switch back to the first style 'function(arg'. Although I like the second (GNU) style the most, it is probably best to use something consistent inside the code base like the first (except for imported code like the libiberty demangler). Cheers, Mark |