|
From: Nicholas N. <n.n...@gm...> - 2018-11-06 00:27:39
|
Thanks! My perception is that `function(arg` and `function( arg` are the most common, and I personally have a strong preference for the former. Also, I think the GNU coding style is an abomination. (Especially how it treats braces!) Nick On Tue, Nov 6, 2018 at 8:07 AM Philippe Waroquiers < phi...@sk...> wrote: > On Mon, 2018-11-05 at 13:24 +1100, Nicholas Nethercote wrote: > > Why'd you do that? This file's style is now less like the style used > throughout most of this codebase and most other C/C++ codebases. > Humph, it looks like I was recently too much working on GDB, that follows > the GNU coding style which mandates 'function (arg' (this is also used > at my work). > > But effectively, doing some grep on the valgrind code basis, we have > various different styles such as > 'function(arg' > 'function (arg' > 'function ( arg' > 'function( arg' > > but it looks like valgrind uses more the first style than the 3 others. > So, I will rather switch back to the first style 'function(arg'. > > Thanks for the comment > > Philippe > > |