Re: [Valgrind-developers] Valgrind on FreeBSD

[Phil L. <plo...@sa...>]

Hi Paul,

In answer to a previous question of yours, I did use --enable-only64bit.

Can you clone my repository, make the changes, then send me a pull request?

Phil

From: Paul Floyd [mailto:pj...@wa...]
Sent: Sunday, March 4, 2018 5:07 AM
To: val...@li...
Subject: Re: [Valgrind-developers] Valgrind on FreeBSD




On 22 Feb 2018, at 23:33, Phil Longstaff <plo...@sa...<mailto:plo...@sa...>> wrote:

I have now built valgrind for freebsd up to 3.13.0. I have a git repository (https://bitbucket.org/plongstaff/valgrind-freebsd-git) which has a 'master' branch which is a clone of the official git repository, and a 'freebsd' branch which has the freebsd changes. These originally came from the work that Stanislav Sedov had, with some additions that we made at Sandvine for some syscalls. These branches allow me to 'git pull' any valgrind source changes, then rebase the freebsd branch to keep it up to date.

'make regtest' builds, but does not pass. I have fixed a few of the problems but not all of them.

Phil
-----Original Message-----
From: pa...@fr...<mailto:pa...@fr...> [mailto:pa...@fr...]
Sent: Thursday, February 22, 2018 3:32 PM
To: val...@li...<mailto:val...@li...>
Subject: Re: [Valgrind-developers] Valgrind on FreeBSD


Hi Phil

Some more feedback for other platforms.

You’ve defined VKI_MAP_STACK in vki-freebsd.h (only) and added it to coregrind/m_aspacemgr/aspacemgr-linux.c without any conditional compilation.

In coregrind/m_debuginfo/readelf.c around line 454 there looks like a code merge issue. The ‘#if !defined(VGO_freebsd) block looks spurious.

coregrind/m_syswrap/syswrap-freebsd.c needs to be conditionally compiled. I added #if defined(VGO_freebsd)

coregrind/m_syswrap/priv_types_n_macros.h has same changes for macOS around line 303

That’s all I needed to change on Linux. macOS and Solaris required quite a few more changes.

Next, there are several linux conditional compilation blocks added to coregrind/m_syswrap/priv_syswrap-generic.h. I reverted all of them, and proceeded to make the minimum changes in sys wrap-generic.c where there are also many linux conditional compilation blocks.

After that I was able to complete the build on all 3 platforms.

A+
Paul