Re: [Valgrind-developers] Valgrind on freebsd

[Phil L. <plo...@sa...>]

Yes, https://bitbucket.org/stass/valgrind-freebsd provides the freebsd port that I am using.

Thanks for answering my questions. I will need to look at whether I can afford to provide maintenance.

Phil

-----Original Message-----
From: Ivo Raisr [mailto:iv...@iv...] 
Sent: Wednesday, October 25, 2017 6:08 AM
To: Phil Longstaff
Cc: val...@li...
Subject: Re: [Valgrind-developers] Valgrind on freebsd

2017-10-24 20:53 GMT+02:00 Phil Longstaff <plo...@sa...>:
> There is a bitbucket.org project (mercurial) which adds freebsd 
> support to valgrind 3.10.1. I have cloned this and have now updated the base to 3.11.0.
> I am planning to update the base to 3.13.0 and would then like to 
> merge the changes upstream to make freebsd a supported OS.
>
>
>
> Since valgrind now uses a git repository, probably the best route is:
>
> 1)      Continue to use bitbucket.org to merge in 3.12.0 and 3.13.0
>
> 2)      Clone valgrind git repository to gitlab
>
> 3)      Add my code as a “freebsd branch”
>
> 4)      Start to feed changes upstream
>
>
>
> Comments? What standards do you have for taking changes? What 
> resources would you need to accept freebsd as a supported OS?

Hello Phil,

Thank you for taking this topic into valgrind-developers.
Do you have in mind https://bitbucket.org/stass/valgrind-freebsd?

Certainly new OS ports are welcome *iff* they are maintained.

The list of requirements was discussed this year at FOSDEM 2017.
There should be:
* some users,
* developer(s) doing maintenance
* developer(s) reachable to answer simple questions about the port
* access to a system to test/compile
* nightly regression build sending results to valgrind-testresults alias
* OS specific regression tests versioned in Valgrind GIT

For Valgrind, just upstreaming the port is not the task end. You (or other developers) cannot disappear after that. There is an ongoing joint effort of the whole Valgrind community to keep Valgrind live on all supported OSes and platforms. See http://valgrind.org/info/platforms.html, Porting Plans.

I have removed TileGx/Linux port this year because it did not satisfy any of the above.
Few years ago, Petr Pavlu and I have successfully upstreamed the Solaris port. I have been maintaining it since then, keeping up with OS and Valgrind development.
Also Tomas Jedlicka, Diane Meirowitz and I have attempted at porting Valgrind to sparc/Linux and sparc/Solaris.
However even if the port was almost ready for upstreaming we decided not to pursue it any longer because of the required maintenance which we could not dedicate to.

These questions must be cleared before considering taking in any of the changes.

As regards the upstreaming process, we would like to see which FreeBSD versions, variants, architectures the port is targeting.
Does it support all production Valgrind analysis tools? Experimental ones?
Then we would like to see the output of 'make regtest' and finally some patches, preferably split into VEX changes, core changes, tool changes, FreeBSD-specific changes (most probably new files). If there are interface changes - they need to be either sweet & short or well understood.
Unfortunately coding standards are not written anywhere - have a look at the existing files around for inspiration. Ideally send a small snapshot early and you will get some comments.

I hope you'll find this useful. Do not hesitate to ask.
Kind regards,
I.