|
From: Ivo R. <iv...@iv...> - 2017-04-24 20:36:00
|
2017-04-24 22:03 GMT+02:00 Matthias Schwarzott <zz...@ge...>: > Am 24.04.2017 um 17:00 schrieb Ivo Raisr: >> Any comments or objections to patch v2 for bug 379039? >> https://bugs.kde.org/show_bug.cgi?id=379039 >> >> I. >> > Hi! > > The code seems to work, but the len variable does not mean length of the > string, so it could be misleading. > > Additionally I am not sure if the function POST(sys_prctl) must also be > modified. Hi Matthias, Thank you for your comments. You are right, I had to modify POST(sys_prctl) so it takes into account that ARG2 might not need to be nul-terminated. > The test memcheck/tests/threadname.c maybe needs more cases: > > * Set threadname to a long string and check that only the first 15 > characters are printed as threadname for the next error. Why? We do not want to do functional testing of libpthread or prctl syscall. > * If possible a test that proves, that POST(sys_prctl) does not access > memory after byte 16 (but I do not know how to test this). That would be appropriate for prctl(get-name) case. Different story. I will attach new patch shortly. I. |