|
From: Matthias S. <zz...@ge...> - 2017-04-24 20:20:56
|
Am 24.04.2017 um 22:03 schrieb Matthias Schwarzott: > Am 24.04.2017 um 17:00 schrieb Ivo Raisr: >> Any comments or objections to patch v2 for bug 379039? >> https://bugs.kde.org/show_bug.cgi?id=379039 >> >> I. >> > Hi! > > The code seems to work, but the len variable does not mean length of the > string, so it could be misleading. > > Additionally I am not sure if the function POST(sys_prctl) must also be > modified. > > The test memcheck/tests/threadname.c maybe needs more cases: > > * Set threadname to a long string and check that only the first 15 > characters are printed as threadname for the next error. I forgot to mention that for this test prctl must be called directly instead of pthread_setname_np as in the existing cases. pthread_setname_np fails with ERANGE without calling prctl. > > * If possible a test that proves, that POST(sys_prctl) does not access > memory after byte 16 (but I do not know how to test this). > > Regards > Matthias > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Valgrind-developers mailing list > Val...@li... > https://lists.sourceforge.net/lists/listinfo/valgrind-developers > |