|
From: <sv...@va...> - 2017-01-10 18:07:14
|
Author: philippe
Date: Tue Jan 10 18:07:07 2017
New Revision: 16195
Log:
xtree: CALLED_FLF must be called only up to ips[0] + minor doc update
Modified:
trunk/coregrind/m_xtree.c
trunk/docs/xml/manual-core.xml
Modified: trunk/coregrind/m_xtree.c
==============================================================================
--- trunk/coregrind/m_xtree.c (original)
+++ trunk/coregrind/m_xtree.c Tue Jan 10 18:07:07 2017
@@ -546,8 +546,8 @@
else
FP("%d\n", called_linenum); //no self cost.
prev_linenum = called_linenum;
- CALLED_FLF(ips_idx-1);
if (ips_idx >= 1) {
+ CALLED_FLF(ips_idx-1);
FP_pos_str(fp, "cfi", called_filename_nr,
called_filename, called_filename_new);
FP_pos_str(fp, "cfn", called_fnname_nr,
Modified: trunk/docs/xml/manual-core.xml
==============================================================================
--- trunk/docs/xml/manual-core.xml (original)
+++ trunk/docs/xml/manual-core.xml Tue Jan 10 18:07:07 2017
@@ -2858,11 +2858,15 @@
</itemizedlist>
-<para>Note that the Callgrind Format is more compact than the Massif Format,
- and contains the full data : there is no filtering during file production,
- filtering is done by visualisers such as kcachegrind. kcachegrind is
- particularly easy to use to analyse big xtree data containing multiple
- events counts or resources consumption.</para>
+<para>Note that for equivalent information, the Callgrind Format is more compact
+ than the Massif Format. However, the Callgrind Format always contains the
+ full data: there is no filtering done during file production, filtering is
+ done by visualisers such as kcachegrind. kcachegrind is particularly easy to
+ use to analyse big xtree data containing multiple events counts or resources
+ consumption. The Massif Format (optionally) only contains a part of the data.
+ For example, the Massif tool might filter some of the data, according to the
+ <option>--threshold</option> option.
+</para>
<para>To clarify the xtree concept, the below gives several extracts of
the output produced by the following commands:
|