[Valgrind-developers] Valgrind: r16160 - in /trunk/coregrind: m_clientstate.c m_syswrap/syswrap-solaris.c

[<sv...@va...>]

Author: iraisr
Date: Mon Nov 28 21:41:28 2016
New Revision: 16160

Log:
Use NULL_STK_ID consistently throughout whole Valgrind.
Follow up to SVN r16159, BZ#373046. 

Modified:
    trunk/coregrind/m_clientstate.c
    trunk/coregrind/m_syswrap/syswrap-solaris.c

Modified: trunk/coregrind/m_clientstate.c
==============================================================================
--- trunk/coregrind/m_clientstate.c (original)
+++ trunk/coregrind/m_clientstate.c Mon Nov 28 21:41:28 2016
@@ -31,6 +31,7 @@
 */
 
 #include "pub_core_basics.h"
+#include "pub_core_threadstate.h"
 #include "pub_core_vki.h"
 #include "pub_core_xarray.h"
 #include "pub_core_clientstate.h"
@@ -50,7 +51,7 @@
 Addr  VG_(clstk_start_base)  = 0;
 /* Initial highest address of the stack segment of the main thread. */
 Addr  VG_(clstk_end)   = 0;
-UWord VG_(clstk_id)    = 0;
+UWord VG_(clstk_id)    = NULL_STK_ID;
 /* Maximum size of the main thread's client stack. */
 SizeT VG_(clstk_max_size) = 0;
 

Modified: trunk/coregrind/m_syswrap/syswrap-solaris.c
==============================================================================
--- trunk/coregrind/m_syswrap/syswrap-solaris.c (original)
+++ trunk/coregrind/m_syswrap/syswrap-solaris.c Mon Nov 28 21:41:28 2016
@@ -195,7 +195,7 @@
       VG_TRACK(die_mem_munmap, a, sizeof(struct vki_sc_shared));
 
    /* Deregister thread's stack. */
-   if (tst->os_state.stk_id != (UWord)-1)
+   if (tst->os_state.stk_id != NULL_STK_ID)
       VG_(deregister_stack)(tst->os_state.stk_id);
 
    /* Tell the tool this thread is exiting. */
@@ -708,14 +708,13 @@
       new_start = new_end + 1 - new_size;
    }
 
-   if (tst->os_state.stk_id == (UWord)-1) {
+   if (tst->os_state.stk_id == NULL_STK_ID) {
       /* This thread doesn't have a stack set yet. */
       VG_(debugLog)(2, "syswrap-solaris",
                        "Stack set to %#lx-%#lx (new) for thread %u.\n",
                        new_start, new_end, tid);
       tst->os_state.stk_id = VG_(register_stack)(new_start, new_end);
-   }
-   else {
+   } else {
       /* Change a thread stack. */
       VG_(debugLog)(2, "syswrap-solaris",
                        "Stack set to %#lx-%#lx (change) for thread %u.\n",
@@ -7037,7 +7036,7 @@
       later by libc by a setustack() call (the getsetcontext syscall). */
    ctst->client_stack_highest_byte = 0;
    ctst->client_stack_szB = 0;
-   vg_assert(ctst->os_state.stk_id == (UWord)(-1));
+   vg_assert(ctst->os_state.stk_id == NULL_STK_ID);
 
    /* Inform a tool that a new thread is created.  This has to be done before
       any other core->tool event is sent. */