[Valgrind-developers] vex: r3252 - in /trunk/priv: guest_ppc_toIR.c host_ppc_isel.c

[<sv...@va...>]

Author: carll
Date: Mon Oct  3 16:30:46 2016
New Revision: 3252

Log:
Fix rounding mode check and instruction stxvl

In BE mode, the function FPU_rounding_mode_isOdd() has the assert
  vassert(mode->Iex.Const.con->Ico.U8 == 0x8);
The value was set using mkU32 but in BE mode the U8 maps to the upper
bits in the memory location not the lower bits.  The comparison was
fixed by changing the .U8 to .U32 to be consistent with how the field
was set.

The stxvl instruction called the 64-bit NOT not the 128-bit NOT when
calculating the store_val.

The stxvx instruction the temp word values were initialized I32 not I64.
Not sure why this wasn't caught on LE.

bugzilla  369175

Modified:
    trunk/priv/guest_ppc_toIR.c
    trunk/priv/host_ppc_isel.c

Modified: trunk/priv/guest_ppc_toIR.c
==============================================================================
--- trunk/priv/guest_ppc_toIR.c (original)
+++ trunk/priv/guest_ppc_toIR.c Mon Oct  3 16:30:46 2016
@@ -20181,10 +20181,10 @@
    {
       UInt ea_off = 0;
       IRExpr* irx_addr;
-      IRTemp word0 = newTemp( Ity_I32 );
-      IRTemp word1 = newTemp( Ity_I32 );
-      IRTemp word2 = newTemp( Ity_I32 );
-      IRTemp word3 = newTemp( Ity_I32 );
+      IRTemp word0 = newTemp( Ity_I64 );
+      IRTemp word1 = newTemp( Ity_I64 );
+      IRTemp word2 = newTemp( Ity_I64 );
+      IRTemp word3 = newTemp( Ity_I64 );
       DIP("stxvx %d,r%u,r%u\n", (UInt)XS, rA_addr, rB_addr);
 
       assign( word0,  binop( Iop_Shr64,
@@ -20346,7 +20346,7 @@
                                       mkexpr( shift ) ),
                                mkexpr( nb_mask ) ),
                         binop( Iop_AndV128,
-                               unop( Iop_Not64, mkexpr( nb_mask ) ),
+                               unop( Iop_NotV128, mkexpr( nb_mask ) ),
                                mkexpr( current_mem) ) ) );
 
       } else {

Modified: trunk/priv/host_ppc_isel.c
==============================================================================
--- trunk/priv/host_ppc_isel.c (original)
+++ trunk/priv/host_ppc_isel.c Mon Oct  3 16:30:46 2016
@@ -1238,7 +1238,7 @@
       return False;
 
    vassert(mode->Iex.Const.con->tag == Ico_U32);
-   vassert(mode->Iex.Const.con->Ico.U8 == 0x8);
+   vassert(mode->Iex.Const.con->Ico.U32 == 0x8);
    return True;
 }