|
From: Carl E. L. <ce...@us...> - 2016-09-07 18:36:29
|
Valgrind Developers: The following patch was submitted to me by Will Schmidt to fix an issue with the Power Altivec configure test. I have created a bugzilla for it, https://bugs.kde.org/show_bug.cgi?id=368412 I have tested the patch on PPC and it seems fine. Since this patch touches an arch independent file it needs to be reviewed and tested by the other platform developers. Please let us know if you find any issues with the patch. It is a small patch, I have attached it below for your convenience. Carl Love ----------------------------------------------------------------------------------------- An earlier change introduced a think-o in the altivec capability check, allowing a false positive if the compiler supported altivec but the hardware did not. --- configure.ac | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index dd4fcb9..62faf4b 100644 --- a/configure.ac +++ b/configure.ac @@ -1379,12 +1379,13 @@ AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[ ]])], [ ac_have_altivec=yes AC_MSG_RESULT([yes]) -AC_DEFINE([HAS_ALTIVEC], 1, +AC_DEFINE([COMPILER_SUPPORTS_ALTIVEC], 1, [Define to 1 if gcc/as can do Altivec.]) ], [ ac_have_altivec=no AC_MSG_RESULT([no]) ]) + CFLAGS=$safe_CFLAGS AM_CONDITIONAL([HAS_ALTIVEC], [test x$ac_have_altivec = xyes \ -a x$HWCAP_HAS_ALTIVEC = xyes]) |