[Valgrind-developers] Valgrind: r15917 - in /trunk: NEWS none/tests/ppc64/Makefile.am

[<sv...@va...>]

Author: carll
Date: Thu Jul 28 17:51:53 2016
New Revision: 15917

Log:
When running the valgrind tests, the jm-insns test is segfaulting when it
attempts to patch instructions as it deals with the ppc64 (BE) function
descriptor. This is actually due to the RELRO option being enabled by default
for the ppc64 (BE) platform, per an upstream binutils change.

Bugzilla 365912 reported by  Will Schmidt, Will supplied the patch to fix the
make file none/tests/ppc64/Makefile.a

Patch tested on Power 7 and Power 8.

Modified:
    trunk/NEWS
    trunk/none/tests/ppc64/Makefile.am

Modified: trunk/NEWS
==============================================================================
--- trunk/NEWS (original)
+++ trunk/NEWS Thu Jul 28 17:51:53 2016
@@ -135,6 +135,7 @@
 364728  Power PC, missing support for several HW registers in
         get_otrack_shadow_offset_wrk()
 365273  Invalid write to stack location reported after signal handler runs
+365912  ppc64BE segfault during jm-insns test (RELRO)
 
 n-i-bz Fix incorrect (or infinite loop) unwind on RHEL7 x86 and amd64
 n-i-bz massif --pages-as-heap=yes does not report peak caused by mmap+munmap

Modified: trunk/none/tests/ppc64/Makefile.am
==============================================================================
--- trunk/none/tests/ppc64/Makefile.am (original)
+++ trunk/none/tests/ppc64/Makefile.am Thu Jul 28 17:51:53 2016
@@ -95,7 +95,7 @@
 HTM_FLAG =
 endif
 
-jm_insns_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames \
+jm_insns_CFLAGS = $(AM_CFLAGS) -Wl,-z,norelro -Winline -Wall -O -g -mregnames \
 			@FLAG_M64@ $(ALTIVEC_FLAG) $(BUILD_FLAG_ALTIVEC)
 
 if HAS_ISA_3_0