Re: [Valgrind-developers] Valgrind: r15880 - in /trunk: NEWS coregrind/m_syswrap/syswrap-generic.c docs/xml/manual-core.xml memcheck/tests/linux/brk.stderr.exp none/tests/linux/brk-overflow1.stderr.exp none/tests/linux/brk-overflow2.stderr.exp

[Philippe W. <phi...@sk...>]

On Mon, 2016-05-23 at 18:50 +0200, Ivo Raisr wrote:
> 2016-05-22 22:48 GMT+02:00 <sv...@va...>:
>         Author: philippe
>         Date: Sun May 22 21:48:09 2016
>         New Revision: 15880
>         
>         Log:
>         Document brk segment limitation, reference manual in limit
>         reached msg.
>         
>         The msg telling brk cannot be extended confuses some users
>         so improve the documentation and have the msg referencing the
>         doc.
> 
> 
> Hello Philippe,
> This limitation is Linux specific so I'd suggest the following edit to
> docs/xml/manual-core.xml:
> -    <para>Valgrind determines at startup the size of the 'brk
> segment'
> -      using the RLIMIT_DATA rlim_cur, with a minimum of 1 MB and a
> -      maximum of 8 MB. Valgrind outputs a message each time a program
> +    <para>On Linux, Valgrind determines at startup the size of the
> 'brk
> +      segment' using the RLIMIT_DATA rlim_cur, with a minimum of 1 MB
> and
> +      a maximum of 8 MB. Valgrind outputs a message each time a
> program
> 
> 
> Do you agree?
> I.
Hello Ivo,
Yes that looks good, please commit.

Reading syswrap-solaris.c  VG_(setup_client_dataseg),
I did not understood that on solaris the brk segment might later be
extended.

Note that what happens on darwin is also not very clear to me: I do
not know if/where the brk segment is initialised.

Thanks

Philippe