|
From: Petar J. <mip...@gm...> - 2015-11-26 23:40:12
|
Hi Leonard, Thank you again for the work on Valgrind. I have previously put some comments on the bug tracker, and I am going to repeat it here. > This version sort-of works-for-me. Unless some specific issues are reported the patches will probably remain as they are. > I would appreciate any advice on how to get these into upstream. I know that adding another ABI expands the combinations that need to be tested. My major concern here is that "sort-of works-for-me". As you understand, adding new ABI means somebody needs to test it on a regular basis. Somebody also needs to use it, and while there are some users of n32 systems, it is still the least used MIPS ABI today, I believe. This does not mean it should be neglected though. But if there are people interested in having it in and maintaining it (or at least reporting issues when they pop up, so the code does not become bit rotten), then we should consider it, but it needs to be in very good shape before it lands. > I use this on cavium hardware but I tested an earlier version inside a debian mips64 qemu vm and it works there as well. I also ran regressions at some point (log attached in bug tracker) and the results were sort-of decent. I have taken a look at the log, and it seems you have not run the full 'make regtest'. What are the results if you run that? For comparison, on Cavium hardware (presumably similar to the one you have) MIPS64 N64 port of Valgrind has less than a dozen failures [1] in regtest. Can you make sure your patches are close to that number for n32? At the same time, please run other MIPS variants and make sure you are not introducing issues/regressions elsewhere. Thanks. Regards, Petar [1] http://www.rt-rk.com/mips-buildbot/builders/EP6300C/builds/746/steps/shell/logs/stdio On Thu, Nov 26, 2015 at 11:13 PM, Crestez Dan Leonard <cdl...@gm...> wrote: > Hello, > > Some time ago I posted some patches adding support for the N32 ABI on mips. > * This is tracked as https://bugs.kde.org/show_bug.cgi?id=345763 > * Link to previous thread: > http://valgrind.10908.n7.nabble.com/RFC-MIPS-N32-abi-support-td54279.html > > I rebased my patches on top of valgrind release 3.11.0. There are no > important changes from the last patches I posted but these should apply > cleanly on top of a released tarball rather than some random SVN head. If > you are interested in N32 support it should be relatively easy to apply the > patches (one to valgrind and one to VEX) and check if it works on your > target system. > > My early versions added an entirely new mips64n32 version similar to > ppc64be and such. Based on comments in the issue tracker I added an VGABI_* > define for mips which greatly reduces the amount of ifdefing required. The > patches are still rather large and messy. > > This version sort-of works-for-me. Unless some specific issues are > reported the patches will probably remain as they are. There is currently > only a very minor conflict if you attempt to apply the patches to trunk. > > I would appreciate any advice on how to get these into upstream. I know > that adding another ABI expands the combinations that need to be tested. I > use this on cavium hardware but I tested an earlier version inside a debian > mips64 qemu vm and it works there as well. I also ran regressions at some > point (log attached in bug tracker) and the results were sort-of decent. > > I used git to manage my patches. You can find detailed step-by-step diffs > on github: > * https://github.com/cdleonard/valgrind/commits/mini-mips64n32-3.11.0 > * https://github.com/cdleonard/valgrind-vex/commits/mini-mips64n32-3.11.0 > > Those repos also contain some octeon-specific fixes which are not required > for n32 support. > > Regards, > Leonard > > > ------------------------------------------------------------------------------ > Go from Idea to Many App Stores Faster with Intel(R) XDK > Give your users amazing mobile app experiences with Intel(R) XDK. > Use one codebase in this all-in-one HTML5 development environment. > Design, debug & build mobile apps & 2D/3D high-impact games for multiple > OSs. > http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140 > _______________________________________________ > Valgrind-developers mailing list > Val...@li... > https://lists.sourceforge.net/lists/listinfo/valgrind-developers > |