|
From: John R. <jr...@bi...> - 2015-11-24 23:17:51
|
On 11/24/2015 02:15 PM, Florian Krohm wrote: > OK, thanks for the explanation. Attached is the patch I'm proposing > which removes the ad-hoc limitation and allows shift amounts up to and > including 31. I looked at the downstream code and it has not problems > handling such shift amounts. > I'm copying Julian to he can chime in and offer an explanation as to why > that limitation existed at all. If there is no yelling I'm going to > commit this in the next couple of days. Shift counts up through 30 [== (2 * 15)] are legal and do work. There is a gray area if the effective absolute value (imm << shift) exceeds something like (1<<18) or (1<<20). Extending or truncating the stack by that much deserves a warning. The danger is "switching segments" without being aware of it. -- |