|
From: Michael D. <mda...@qn...> - 2015-11-24 20:14:46
|
> are there other values >4 possible, that we should handle as well? Shifts are 5 bits, so its possible this value could be as high as 31. Like the other patch, the check could/should probably just be removed altogether. It was just not clear why it was limited in the first place, so I only bumped it as needed. ________________________________________ From: Florian Krohm [fl...@ei...] Sent: Tuesday, November 24, 2015 2:48 PM To: Michael Daniels; val...@li... Subject: Re: [Valgrind-developers] [PATCH][VEX] Bump allowed shift value for "add.w reg, sp, reg, lsl #N" I'm not familiar with arm. But I'm wondering whether allowing teh value 4 here is the right thing to do. Or, phrased differently: are there other values >4 possible, that we should handle as well? Florian On 19.11.2015 17:51, Michael Daniels wrote: > Hello, > > When using GCC 5.2 I am seeing this assembly generated in some cases: > > add.w reg, sp, reg, lsl #4 > > The current limit is 3 though, so it was causing it to be caught as an unhandled instruction. > > Patch attached to bump the number from 3 to 4. > > Thanks, > > Mike > --------------------------------------------------------------------- > This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful. > > > > ------------------------------------------------------------------------------ > > > > _______________________________________________ > Valgrind-developers mailing list > Val...@li... > https://lists.sourceforge.net/lists/listinfo/valgrind-developers > |