|
From: Mark W. <mj...@re...> - 2015-11-17 09:41:50
|
On Mon, 2015-11-16 at 21:35 +0100, Ivo Raisr wrote: > Thank you a lot for an explanation and guidance. > Please have a look at the patch attached to bug: > 355454 do not intercept malloc related symbols from the runtime linker > https://bugs.kde.org/show_bug.cgi?id=355454 Yes, that looks like the right way to fix this. I would expand the comment a bit to make sure people looking at it later know what it really refers to. Maybe start with "When searching for global public symbols (like for the somalloc synonym symbols), exclude...". > Currently it filters out only Solaris runtime linker. Linux runtime linkers > could > be filtered out as well but I am not sure which ones are relevant. There > are just > too many in pub_tool_redir.h... Yeah, it seems that is a bit of a mess :{ Every platform/arch combination seems to invent their own name for the dynamic linker. I don't believe there is an easy way to catch them all. Independent from this fix we might want to introduce a new redir function Bool VG_(is_soname_ld_so) (const HChar* soname) that a tool can use to test whether the so they are looking at is the dynamic loader. See helgrind/hg_main.c (is_in_dynamic_linker_shared_object) for another use. Thanks, Mark |