Re: [Valgrind-developers] Valgrind: r15689 - in /trunk: coregrind/m_syswrap/syswrap-solaris.c include/vki/vki-solaris.h memcheck/tests/solaris/scalar_ioctl.c memcheck/tests/solaris/scalar_ioctl.stderr.exp

[Florian K. <fl...@ei...>]

On 29.09.2015 16:23, sv...@va... wrote:

> +static void sys_ioctl_SIOCGLIFCONF_2(void)
> +{
> +   struct lifconf lifc;
> +   char buf[5];

If this buffer is always large enough, could you add a comment saying
so? In the past we had many fixed size buffers that were not large
enough and I got rid of almost all of them. For the remaining fixed size
buffers I added a comment (where appropriate) to make it clear for the
cursory reader that the array bound is not a problem.

Thanks,
	Florian