|
From: Florian K. <fl...@ei...> - 2015-09-16 17:44:08
|
Carl,
looks good all in all. 2 comments below:
On 16.09.2015 19:06, Carl E. Love wrote:
> + case Iop_I64UtoF32:
> + case Iop_I64StoD64: {
> + int rc;
> + /* IROps require a processor that supports ISA 2.06 or newer */
> + rc = system(MIN_POWER_ISA " 2.06 ");
> + rc /= 256;
> + /* MIN_POWER_ISA returns 1 if underlying HW supports the
> + * specified ISA or newer.
> + */
> + if (rc == 0) return NULL;
> + if (rc > 2) {
> + panic(" ERROR, min_power_isa() return code is invalid.\n");
> + exit(1);
The exit(1) isn't needed. The panic function already does that.
> +++ b/tests/min_power_isa.c
> @@ -0,0 +1,63 @@
> +#include <stdio.h>
> +#include <stdbool.h>
stdbool.h isn't needed. But you need to include <string.h> for strcmp.
With those changes you can check it in to HEAD. Julian will cherry-pick
changes from HEAD later and merge them to the 3.11 branch.
Florian
|