|
From: Matthias S. <zz...@ge...> - 2015-09-16 17:42:35
|
Am 16.09.2015 um 19:06 schrieb Carl E. Love: > Florian: > > Thanks for the feedback. > >> Hmm... The Makefile defines HAS_ISA_2_05 etc... not HWCAP_HAS_ISA_2_05 > > Yes, that was messed up and not working correctly. I had tested it and > it all seemed to work. Not sure how I missed that. Anyway, I added > some debug capability to min_power_isa.c to make it easier to verify it > is correct. I also added some more error checking on the input. > > I made the other changes you suggested as well. Here is the updated > patch. Let me know if you see anything else. > Hi! I cannot check all this, but just from looking at the code, the exit-code of min_power_isa is not respecting the normal conventions. Normally a success-value is represented by an exit-code of 0. Then min_power_isa could then be used with normal shell-logic, e.g. as precondition for vgtest etc. or in command-lines like this: # min_power_isa 2.06 && echo "isa 2.06 is supported" Regards Matthias |