|
From: Carl E. L. <ce...@us...> - 2015-09-14 16:03:25
|
On Sat, 2015-09-12 at 20:50 +0200, Florian Krohm wrote:
> Carl,
>
> while looking at the vbit-test failure on ppc32 I noticed that in
> guest_ppc_toIR.c all dis_dfp_XYZZY functions are guarded by
> if (!allow_DFP) goto decode_noDFP
> except the two below. An oversight ?
Florian:
Yes, this does appear to be an oversight as these instructions use an
Iop that was created specifically for these instructions. PPC32 does
not have DFP support so trying to test the Iop on ppc32 would be an
issue.
Carl Love
> Florian
>
>
> Index: VEX/priv/guest_ppc_toIR.c
> ===================================================================
> --- VEX/priv/guest_ppc_toIR.c (revision 3187)
> +++ VEX/priv/guest_ppc_toIR.c (working copy)
> @@ -19172,6 +19172,7 @@
> case 0x322: // POWER 7 inst, dcffix - DFP convert from fixed
> if (!allow_VX)
> goto decode_failure;
> + if (!allow_DFP) goto decode_noDFP;
> if (dis_dfp_fmt_conv( theInstr ))
> goto decode_success;
> goto decode_failure;
> @@ -19598,6 +19599,7 @@
> goto decode_success;
> goto decode_failure;
> case 0xA2: // dtstexq - DFP Test exponent Quad
> + if (!allow_DFP) goto decode_noDFP;
> if (dis_dfp_exponent_test( theInstr ) )
> goto decode_success;
> goto decode_failure;
>
|