|
From: Mark W. <mj...@re...> - 2015-09-04 09:43:07
|
On Wed, 2015-09-02 at 00:23 +0200, Mark Wielaard wrote: > On Mon, Aug 24, 2015 at 10:19:01PM +0200, Mark Wielaard wrote: > > I hoped to fix the SIGABRT issue with tc18 and tc20 for sem_post > > in a similar way. See attached. > > > > It does "fix" the tc18 case, but not the tc20 case. > > > > Since hellgrind doesn't actually see the failure now it doesn't report > > anything. Which works for tc18 since there is an alternate exp file with > > that result (silent bad sem_post), but tc20 doesn't have an alternative > > where there is no EINVAL so it still reports an error. But at least not > > an abort, but a missing EINVAL. > > > > I do think glibc not detecting a bad semaphore might be allowed, so > > maybe we could just add an alternative tc20.exp that just doesn't see > > the EINVAL. Or would that be too much "cheating"? > > So if nobody objects I would like to push the attached patch. Since nobody loudly objected I have now pushed this as valgrind svn r15620. Please yell and scream if this breaks things for anybody. Thanks, Mark |