Re: [Valgrind-developers] Valgrind: r15565 - in /trunk: drd/tests/ helgrind/tests/

[Tom H. <to...@co...>]

On 18/08/15 18:08, Mark Wielaard wrote:
> On Tue, 2015-08-18 at 15:37 +0100, Tom Hughes wrote:
>> On 18/08/15 15:34, Julian Seward wrote:
>>> On 18/08/15 16:21, Rhys Kidd wrote:
>>>> Seeing build failure with 'make check' on OS X as follows. Will get a
>>>
>>>> ./safe-pthread.h:29:19: error: token is not a valid binary operator in a
>>>> preprocessor subexpression
>>>> #if __GLIBC_PREREQ(2,20) && ( defined(__i386__) || defined(__x86_64__) )
>>>>       ~~~~~~~~~~~~~~^
>>>
>>> Yes, I imagine __GLIBC_PREREQ doesn't exist on OS X.  What about this?
>>>
>>> #if defined(__GLIBC_PREREQ) \
>>>       && __GLIBC_PREREQ(2,20) && ( defined(__i386__) || defined(__x86_64__) )
>>>
>>> Will that fix it?
>>
>> Should do. Sorry, stole that from the main tc20 code without paying
>> attention to all the humps it jumped through to define it on other
>> platforms.
>
> Do we really need the #if?
> Can't we just always install the sigill handler?

That would work as well. I was just being conservative...

Tom

-- 
Tom Hughes (to...@co...)
http://compton.nu/