[Valgrind-developers] Valgrind: r15467 - in /trunk: NEWS coregrind/m_ume/elf.c

[<sv...@va...>]

Author: iraisr
Date: Sat Aug  1 13:11:09 2015
New Revision: 15467

Log:
Fix hard-to-understand code in VG_(load_ELF)().
Although it is a valid C [1], the closing bracket for "case PT_INTERP" is misplaced.
Fixes BZ #350854.

[1] https://en.wikipedia.org/wiki/Duff%27s_device#Mechanism

Modified:
    trunk/NEWS
    trunk/coregrind/m_ume/elf.c

Modified: trunk/NEWS
==============================================================================
--- trunk/NEWS (original)
+++ trunk/NEWS Sat Aug  1 13:11:09 2015
@@ -272,6 +272,7 @@
 350809  Fix none/tests/async-sigs for Solaris
 350811  Remove reference to --db-attach which has been removed.
 350813  Use handwritten memcheck assembly helpers on x86/Solaris in addition to {arm,x86}-linux
+350854  hard-to-understand code in VG_(load_ELF)()
 n-i-bz  Provide implementations of certain compiler builtins to support
         compilers who may not provide those
 n-i-bz  Old STABS code is still being compiled, but never used. Remove it.

Modified: trunk/coregrind/m_ume/elf.c
==============================================================================
--- trunk/coregrind/m_ume/elf.c (original)
+++ trunk/coregrind/m_ume/elf.c Sat Aug  1 13:11:09 2015
@@ -443,6 +443,7 @@
                interp_size = end;
          }
          break;
+         }
 
 #     if defined(PT_GNU_STACK) || defined(PT_SUNWSTACK)
 #     if defined(PT_GNU_STACK)
@@ -463,7 +464,6 @@
          // do nothing
          break;
       }
-      }
    }
 
    if (info->phdr == 0)