Author: florian
Date: Thu May 21 23:41:39 2015
New Revision: 15269
Log:
Remove an incorrect assertion. Need to consider SkShmC segments as well.
Added:
trunk/none/tests/linux/mremap6.c
trunk/none/tests/linux/mremap6.stderr.exp
trunk/none/tests/linux/mremap6.vgtest
Modified:
trunk/coregrind/m_aspacemgr/aspacemgr-linux.c
trunk/none/tests/linux/ (props changed)
trunk/none/tests/linux/Makefile.am
Modified: trunk/coregrind/m_aspacemgr/aspacemgr-linux.c
==============================================================================
--- trunk/coregrind/m_aspacemgr/aspacemgr-linux.c (original)
+++ trunk/coregrind/m_aspacemgr/aspacemgr-linux.c Thu May 21 23:41:39 2015
@@ -3001,9 +3001,6 @@
/* Mark the new area based on the old seg. */
if (seg.kind == SkFileC) {
seg.offset += ((ULong)old_addr) - ((ULong)seg.start);
- } else {
- aspacem_assert(seg.kind == SkAnonC);
- aspacem_assert(seg.offset == 0);
}
seg.start = new_addr;
seg.end = new_addr + new_len - 1;
Modified: trunk/none/tests/linux/Makefile.am
==============================================================================
--- trunk/none/tests/linux/Makefile.am (original)
+++ trunk/none/tests/linux/Makefile.am Thu May 21 23:41:39 2015
@@ -13,6 +13,7 @@
mremap3.stderr.exp mremap3.stdout.exp mremap3.vgtest \
mremap4.stderr.exp mremap4.vgtest \
mremap5.stderr.exp mremap5.vgtest \
+ mremap6.stderr.exp mremap6.vgtest \
pthread-stack.stderr.exp pthread-stack.vgtest \
stack-overflow.stderr.exp stack-overflow.vgtest
@@ -25,6 +26,7 @@
mremap3 \
mremap4 \
mremap5 \
+ mremap6 \
pthread-stack \
stack-overflow
Added: trunk/none/tests/linux/mremap6.c
==============================================================================
--- trunk/none/tests/linux/mremap6.c (added)
+++ trunk/none/tests/linux/mremap6.c Thu May 21 23:41:39 2015
@@ -0,0 +1,31 @@
+#define _GNU_SOURCE
+#include <stdio.h>
+#include <stdlib.h>
+#include <assert.h>
+#include <sys/ipc.h>
+#include <sys/shm.h>
+#include <sys/stat.h>
+#include <sys/mman.h>
+
+static void *mkmap(unsigned sz)
+{
+ int shmid = shmget(IPC_PRIVATE, sz,
+ IPC_CREAT | IPC_EXCL | S_IRUSR | S_IWUSR);
+ assert(shmid != -1);
+
+ void *addr = shmat(shmid, NULL, 0);
+ assert(addr != (void *)-1);
+
+ return addr;
+}
+
+int main()
+{
+ void *np, *p;
+
+ p = mkmap(1024*1024);
+ np = mremap(p, 1024*1024, 2048*1024, MREMAP_MAYMOVE); /* grow, maymove */
+ assert(np != (void *)-1);
+
+ return 0;
+}
Added: trunk/none/tests/linux/mremap6.stderr.exp
==============================================================================
(empty)
Added: trunk/none/tests/linux/mremap6.vgtest
==============================================================================
--- trunk/none/tests/linux/mremap6.vgtest (added)
+++ trunk/none/tests/linux/mremap6.vgtest Thu May 21 23:41:39 2015
@@ -0,0 +1,5 @@
+prog: mremap6
+vgopts: -q
+# This testcase used to run into an assertion. Therefore cannot use
+# the default filter because need to see lines beginning with --<pid> .....
+stderr_filter: ../../../tests/filter_addresses
|