|
From: Rhys K. <rhy...@gm...> - 2015-05-01 00:03:03
|
No regressions seen on OS X for r15109. The change looks fine for this platform, good pickup. On 18 April 2015 at 20:35, Florian Krohm <fl...@ei...> wrote: > On 17.04.2015 12:57, Julian Seward wrote: > > On 17/04/15 12:47, Florian Krohm wrote: > > > >> Now, looking at the linux side of things: > >> > >> VG_TRACK( new_mem_stack_signal, addr - VG_STACK_REDZONE_SZB, > >> size + VG_STACK_REDZONE_SZB, tid ); > >> > >> With your above argument (which is platform neutral), this does not look > >> right either. > > > > I agree. It might be one of those things which has always been wrong, > but > > which nobody really noticed until now. > > > > If you're amenable to it, I'd suggest to use simply |size| in the new > > merged-up version. If we get it wrong somehow, the worst that can happen > > is that we'll get flooded with false positive errors in signal handlers > > and we'll soon know something isn't right. So it's a low-risk change > IMO. > > > > r15109. Regtested on x86-64, s390, ppc64 > > Florian > > > > ------------------------------------------------------------------------------ > BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT > Develop your own process in accordance with the BPMN 2 standard > Learn Process modeling best practices with Bonita BPM through live > exercises > http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- > event?utm_ > source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF > _______________________________________________ > Valgrind-developers mailing list > Val...@li... > https://lists.sourceforge.net/lists/listinfo/valgrind-developers > |