|
From: Philippe W. <phi...@sk...> - 2015-04-20 21:26:59
|
Nice cleanup.
One small comment: wouldn't the description of VG_(sr_as_string)()
better be put in the .h rather than in the .c file ?
The fact that the memory is static (or must be freed by the caller)
is better described there ?
Philippe
On Mon, 2015-04-20 at 20:42 +0000, sv...@va... wrote:
> +/* ---------------------------------------------------------------------
> + VG_(sr_as_string)()
> + ------------------------------------------------------------------ */
> +
> +/* Return a textual representation of a SysRes value in a statically
> + allocated buffer. The buffer will be overwritten with the next
> + invocation. */
> +#if defined(VGO_linux)
> +// FIXME: Does this function need to be adjusted for MIPS's _valEx ?
> +const HChar *VG_(sr_as_string) ( SysRes sr )
> +{
....
> Modified: trunk/include/pub_tool_libcprint.h
> ==============================================================================
> --- trunk/include/pub_tool_libcprint.h (original)
> +++ trunk/include/pub_tool_libcprint.h Mon Apr 20 21:42:42 2015
> @@ -154,6 +154,9 @@
> /* Flush any output cached by previous calls to VG_(message) et al. */
> extern void VG_(message_flush) ( void );
>
> +/* Return a SysRes value as a character string. */
> +extern const HChar *VG_(sr_as_string) ( SysRes sr );
> +
> #endif // __PUB_TOOL_LIBCPRINT_H
>
> /*--------------------------------------------------------------------*/
>
>
> ------------------------------------------------------------------------------
> BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
> Develop your own process in accordance with the BPMN 2 standard
> Learn Process modeling best practices with Bonita BPM through live exercises
> http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
> source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
> _______________________________________________
> Valgrind-developers mailing list
> Val...@li...
> https://lists.sourceforge.net/lists/listinfo/valgrind-developers
|