|
From: Florian K. <fl...@ei...> - 2015-04-18 10:35:36
|
On 17.04.2015 12:57, Julian Seward wrote: > On 17/04/15 12:47, Florian Krohm wrote: > >> Now, looking at the linux side of things: >> >> VG_TRACK( new_mem_stack_signal, addr - VG_STACK_REDZONE_SZB, >> size + VG_STACK_REDZONE_SZB, tid ); >> >> With your above argument (which is platform neutral), this does not look >> right either. > > I agree. It might be one of those things which has always been wrong, but > which nobody really noticed until now. > > If you're amenable to it, I'd suggest to use simply |size| in the new > merged-up version. If we get it wrong somehow, the worst that can happen > is that we'll get flooded with false positive errors in signal handlers > and we'll soon know something isn't right. So it's a low-risk change IMO. > r15109. Regtested on x86-64, s390, ppc64 Florian |