|
From: Zhigang L. <zl...@ez...> - 2015-04-10 02:30:34
|
________________________________________ From: Florian Krohm <fl...@ei...> Sent: Thursday, April 9, 2015 12:46 PM To: js...@ac...; Valgrind Developers Cc: Zhigang Liu Subject: Re: [Valgrind-developers] Linux/TileGX port: last call for comments On 09.04.2015 15:48, Julian Seward wrote: > > Bug 339778 (https://bugs.kde.org/show_bug.cgi?id=339778) contains > patches for a port to TileGx, a 64 bit CPU. There has been quite > some reviewing and re-working of the patches. From my point of > view they are now ready to land. > > Are there any more comments or concerns regarding this bug? If so > please say so now. If not I propose to land it in the next day or so. This looks all pretty good to me. I added a few comments to the BZ. All minor stuff except the absence of insn tests. [ZhiGang] We will add instruction tests separately. It is not ready now. One thing I'd like to bring up is a nightly build with results posted to the mailing list. We already have enough ports without those and generally no idea how well those ports work and/or how they brake when new stuff gets added. We want to be able to observe that. [Zhigang] The regress test shows 20+ failures as post in my previous email today. Most of them are due to the mismatch source file line # given by stack trace. The mismatched line number are very close to expected within +/-3. Apparently, we need improve the stack back trace later. Regarding the maintaining: we can periodically(say once a week) pull the trunk and run on TileGX linux machine and post the results on this mail-list. Florian |