Re: [Valgrind-developers] Linux/TileGX port: last call for comments

[Zhigang L. <zl...@ez...>]

Florian an all who concerns,

I am in the middle to address your new comments, especially, the format issue of "guest_tilegx_toIR.c", which is based on a generated template file.  
I have to do it line by line to correct the format, I hope I could finish today, unless you think we could do it after the merge.

This was the regression test result I had run with the patches last time. I could improve it further.  About half of the failures are due to line # given by stack trace, the line # are within +/- 3  range compared  to the expected. Apparently the stack trace code need some enhancement. We could do it later on.
-----------------
== 539 tests, 21 stderr failures, 1 stdout failure, 1 stderrB failure, 3 stdoutB failures, 1 post failure ==


Thanks 

ZhiGang



-----Original Message-----
From: Florian Krohm [mailto:fl...@ei...] 
Sent: Thursday, April 09, 2015 12:47 PM
To: js...@ac...; Valgrind Developers
Cc: Zhigang Liu
Subject: Re: [Valgrind-developers] Linux/TileGX port: last call for comments

On 09.04.2015 15:48, Julian Seward wrote:
> 
> Bug 339778 (https://bugs.kde.org/show_bug.cgi?id=339778) contains 
> patches for a port to TileGx, a 64 bit CPU.  There has been quite some 
> reviewing and re-working of the patches.  From my point of view they 
> are now ready to land.
> 
> Are there any more comments or concerns regarding this bug?  If so 
> please say so now.  If not I propose to land it in the next day or so.

This looks all pretty good to me.
I added a few comments to the BZ. All minor stuff except the absence of insn tests.

One thing I'd like to bring up is a nightly build with results posted to the mailing list. We already have enough ports without those and generally no idea how well those ports work and/or how they brake when new stuff gets added. We want to be able to observe that.

    Florian