|
From: Julian S. <js...@ac...> - 2015-04-08 09:15:53
|
On 08/04/15 11:05, Florian Krohm wrote: > The advantage of the Boolean field would be that it is architecture > neutral. Yes. If we did make such a change, I would prefer the Boolean version rather than embedding the syscall number. (eg, which isn't even a single number on Darwin). I'd also prefer to do it by removing _valEx from all the Linux targets except mips*-linux and having a mips-specific version that includes _valEx and the new bool. This avoids having fields with no meaning for non-mips targets, which IMO would be confusing. > Isn't there also a correctness issue with the status quo? You might get > a false result by comparing a SysRes from a pipe call with a SysRes from > a non-pipe call. That is true, but that is not a mips-specific problem -- it applies to all targets. You need to know that two SysRess came from the same syscall before comparing them. Part of the value of this discussion (I've now understood) is to more clearly define the semantics of SysRes that it so far has been. As well as fixing the problem. J |