|
From: Florian K. <fl...@ei...> - 2015-04-08 09:05:14
|
On 08.04.2015 09:52, Petar Jovanovic wrote: > In order to set that boolean field correctly, at each point in which we > create SysRes, we need to know for which system call SysRes was created. > Similar solution - that would likely require similar number of changes - > would be to have SysRes carry its system call number. The advantage of the Boolean field would be that it is architecture neutral. It simply would be set to True for all architectures other than mips. If we recorded the system call number more work would be required for other architectures (or something less intuitive such as setting a fake system call number). So I'm favouring the Boolean field as well. Isn't there also a correctness issue with the status quo? You might get a false result by comparing a SysRes from a pipe call with a SysRes from a non-pipe call. If I understand correctly, such a comparison should produce a "not-equal" result whereas today it could produce an "equal" result. Florian |