|
From: Petar J. <mip...@gm...> - 2015-04-03 02:14:34
|
Hi Florian, Sorry for not responding to this earlier. Field _valEx is used on MIPS only for pipe system call when kernel can return an array of two file descriptors. Otherwise, this field is undefined (actually, it has a value that happened to be in v1 register, which can be an arbitrary value and it is not deterministic). Thus, comparing _valEx does not make sense for an arbitrary SysRes. Your yesterday's change r15060 breaks MIPS port in general, as comparing _valEx will fail immediately. Petar On Mon, Mar 23, 2015 at 8:36 PM, Florian Krohm <fl...@ei...> wrote: > r12616 (merge mips32 port) adds a new field '_valEx' to the SysRes > structure. However, the function sr_EQ which tests two SysRes values for > equality ignores that field. > That doesn't look right. But in case it is correct there should be some > verbiage as to why _valEx does not matter for equality. > > Florian > |