|
From: Crestez D. L. <cdl...@gm...> - 2015-03-27 13:08:22
|
On 03/27/2015 06:57 AM, Maran Pakkirisamy wrote: > > > On 03/26/2015 06:58 PM, Crestez Dan Leonard wrote: >> If you think that this sort of patch is acceptable the next step would be to post a bug in the tracker, right? > There is already a patch posted at > https://bugs.kde.org/show_bug.cgi?id=328670 to fix this issue. Please > check if the patch helps you. > Hello, I tested that patch and it works too. The patch is probably faster because it only assigns to k0 at specific points instead of every emulated syscall. Overwriting after every syscall is closer to what the kernel actually does, but it should only matter if userspace play with k0 on it's own. I see that that patch was retracted and the bug closed as "wontfix". It's not clear why it's OK to include support for cavium proprietary instructions but not proprietary kernel features. Especially since it's such a very small patch. I believe the patch should be applied. Having valgrind work (almost) out of the box on octeon seems like a good thing. Regards, Leonard |