|
From: <sv...@va...> - 2015-03-26 21:32:11
|
Author: philippe
Date: Thu Mar 26 21:32:03 2015
New Revision: 15039
Log:
Have the very detailed gdbsrv debuglog (e.g. exchange of packets
between GDB and V gdbsrv, fetching/setting registers, ...) done
at debuglog level 3 instead of 1.
This allows to do gdbsrv commands at debuglog level 2
without seeing too much trace.
Modified:
trunk/coregrind/m_gdbserver/remote-utils.c
trunk/coregrind/m_gdbserver/server.c
trunk/coregrind/m_gdbserver/target.c
Modified: trunk/coregrind/m_gdbserver/remote-utils.c
==============================================================================
--- trunk/coregrind/m_gdbserver/remote-utils.c (original)
+++ trunk/coregrind/m_gdbserver/remote-utils.c Thu Mar 26 21:32:03 2015
@@ -852,16 +852,16 @@
}
if (noack_mode)
- dlog(1, "putpkt (\"%s\"); [no ack]\n", buf2);
+ dlog(3, "putpkt (\"%s\"); [no ack]\n", buf2);
else
- dlog(1,"putpkt (\"%s\"); [looking for ack]\n", buf2);
+ dlog(3,"putpkt (\"%s\"); [looking for ack]\n", buf2);
if (noack_mode)
break;
cc = readchar (1);
if (cc > 0)
- dlog(1, "[received '%c' (0x%x)]\n", cc, cc);
+ dlog(3, "[received '%c' (0x%x)]\n", cc, cc);
if (cc <= 0) {
if (cc == 0)
@@ -997,7 +997,7 @@
c = readchar (0);
if (c == '$')
break;
- dlog(1, "[getpkt: discarding char '%c']\n", c);
+ dlog(3, "[getpkt: discarding char '%c']\n", c);
if (c < 0)
return -1;
}
@@ -1029,16 +1029,16 @@
}
if (noack_mode)
- dlog(1, "getpkt (\"%s\"); [no ack] \n", buf);
+ dlog(3, "getpkt (\"%s\"); [no ack] \n", buf);
else
- dlog(1, "getpkt (\"%s\"); [sending ack] \n", buf);
+ dlog(3, "getpkt (\"%s\"); [sending ack] \n", buf);
if (!noack_mode) {
if (!ensure_write_remote_desc()) {
dlog(1, "getpkt(write ack) no write_remote_desc");
}
VG_(write) (write_remote_desc, "+", 1);
- dlog(1, "[sent ack]\n");
+ dlog(3, "[sent ack]\n");
}
return bp - buf;
Modified: trunk/coregrind/m_gdbserver/server.c
==============================================================================
--- trunk/coregrind/m_gdbserver/server.c (original)
+++ trunk/coregrind/m_gdbserver/server.c Thu Mar 26 21:32:03 2015
@@ -618,7 +618,7 @@
if (to == NULL) to = end;
decode_address (&sig, from, to - from);
pass_signals[(int)sig] = 1;
- dlog(1, "pass_signal gdb_nr %d %s\n",
+ dlog(3, "pass_signal gdb_nr %d %s\n",
(int)sig, target_signal_to_name(sig));
from = to;
if (*from == ';') from++;
Modified: trunk/coregrind/m_gdbserver/target.c
==============================================================================
--- trunk/coregrind/m_gdbserver/target.c (original)
+++ trunk/coregrind/m_gdbserver/target.c Thu Mar 26 21:32:03 2015
@@ -339,7 +339,7 @@
if (mod && VG_(debugLog_getLevel)() > 1) {
char bufimage [2*size + 1];
heximage (bufimage, buf, size);
- dlog(2, "fetched register %d size %d name %s value %s tid %d status %s\n",
+ dlog(3, "fetched register %d size %d name %s value %s tid %d status %s\n",
regno, size, the_low_target.reg_defs[regno].name, bufimage,
tid, VG_(name_of_ThreadStatus) (tst->status));
}
@@ -449,7 +449,7 @@
int valgrind_read_memory (CORE_ADDR memaddr, unsigned char *myaddr, int len)
{
const void *sourceaddr = C2v (memaddr);
- dlog(2, "reading memory %p size %d\n", sourceaddr, len);
+ dlog(3, "reading memory %p size %d\n", sourceaddr, len);
if (VG_(am_is_valid_for_client) ((Addr) sourceaddr,
len, VKI_PROT_READ)
|| (hostvisibility
@@ -463,11 +463,12 @@
}
}
-int valgrind_write_memory (CORE_ADDR memaddr, const unsigned char *myaddr, int len)
+int valgrind_write_memory (CORE_ADDR memaddr,
+ const unsigned char *myaddr, int len)
{
Bool is_valid_client_memory;
void *targetaddr = C2v (memaddr);
- dlog(2, "writing memory %p size %d\n", targetaddr, len);
+ dlog(3, "writing memory %p size %d\n", targetaddr, len);
is_valid_client_memory
= VG_(am_is_valid_for_client) ((Addr)targetaddr, len, VKI_PROT_WRITE);
if (is_valid_client_memory
|