Re: [Valgrind-developers] Linux 4.0-rc1

[Julian S. <js...@ac...>]

This looks good to me, with one proviso: I'd prefer to have the minimum
version be 2.6 rather than 2.4.  I think it's quite likely that the
current code base won't work with 2.4.

J

On 23/02/15 20:20, Christian Borntraeger wrote:
> Am 23.02.2015 um 17:04 schrieb Florian Krohm:
>> I'd say we should check the other way round. Namely, that the kernel is
>> not older than 2.4 and issue an error otherwise. Even though it is
>> probably unlikely to encounter a kernel as old as that.
>> The code may have implicit assumptions on certain kernel features only
>> present in 2.4 or later.
> 
> So something like:
> 
> Index: configure.ac
> ===================================================================
> --- configure.ac	(Revision 14904)
> +++ configure.ac	(Arbeitskopie)
> @@ -325,20 +325,14 @@
>          kernel=`uname -r`
>  
>          case "${kernel}" in
> -             2.6.*|3.*) 
> -        	    AC_MSG_RESULT([2.6.x/3.x family (${kernel})])
> -        	    AC_DEFINE([KERNEL_2_6], 1, [Define to 1 if you're using Linux 2.6.x or Linux 3.x])
> +             0.*|1.*|2.0*|2.1*|2.2*|2.3*) 
> +        	    AC_MSG_RESULT([unsupported (${kernel})])
> +        	    AC_MSG_ERROR([Valgrind needs a Linux kernel >= 2.4])
>          	    ;;
>  
> -             2.4.*) 
> -        	    AC_MSG_RESULT([2.4 family (${kernel})])
> -        	    AC_DEFINE([KERNEL_2_4], 1, [Define to 1 if you're using Linux 2.4.x])
> -        	    ;;
> -
> -             *) 
> -        	    AC_MSG_RESULT([unsupported (${kernel})])
> -        	    AC_MSG_ERROR([Valgrind works on kernels 2.4, 2.6])
> -        	    ;;
> +             *)
> +        	    AC_MSG_RESULT([2.4 or later (${kernel})])
> +                    ;;
>          esac
>  
> 
> 
> ------------------------------------------------------------------------------
> Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
> from Actuate! Instantly Supercharge Your Business Reports and Dashboards
> with Interactivity, Sharing, Native Excel Exports, App Integration & more
> Get technology previously reserved for billion-dollar corporations, FREE
> http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk
> _______________________________________________
> Valgrind-developers mailing list
> Val...@li...
> https://lists.sourceforge.net/lists/listinfo/valgrind-developers
>