[Valgrind-developers] Valgrind: r14796 - in /trunk: coregrind/m_syswrap/syswrap-arm-linux.c coregrind/m_syswrap/syswrap-arm64-linux.c coregrind/m_syswrap/syswrap-darwin.c coregrind/m_syswrap/syswrap-s390x-linux.c drd/drd_semaphore.c

[<sv...@va...>]

Author: florian
Date: Sat Nov 29 17:50:10 2014
New Revision: 14796

Log:
Fix a few VG_(message) invocations. The function does not add a 
newline character under the covers.

Modified:
    trunk/coregrind/m_syswrap/syswrap-arm-linux.c
    trunk/coregrind/m_syswrap/syswrap-arm64-linux.c
    trunk/coregrind/m_syswrap/syswrap-darwin.c
    trunk/coregrind/m_syswrap/syswrap-s390x-linux.c
    trunk/drd/drd_semaphore.c

Modified: trunk/coregrind/m_syswrap/syswrap-arm-linux.c
==============================================================================
--- trunk/coregrind/m_syswrap/syswrap-arm-linux.c (original)
+++ trunk/coregrind/m_syswrap/syswrap-arm-linux.c Sat Nov 29 17:50:10 2014
@@ -497,13 +497,12 @@
 
    default:
       /* should we just ENOSYS? */
-      VG_(message)(Vg_UserMsg, "");
-      VG_(message)(Vg_UserMsg, "Unsupported clone() flags: 0x%lx", ARG1);
-      VG_(message)(Vg_UserMsg, "");
-      VG_(message)(Vg_UserMsg, "The only supported clone() uses are:");
-      VG_(message)(Vg_UserMsg, " - via a threads library (LinuxThreads or NPTL)");
-      VG_(message)(Vg_UserMsg, " - via the implementation of fork or vfork");
-      VG_(message)(Vg_UserMsg, " - for the Quadrics Elan3 user-space driver");
+      VG_(message)(Vg_UserMsg, "Unsupported clone() flags: 0x%lx\n", ARG1);
+      VG_(message)(Vg_UserMsg, "\n");
+      VG_(message)(Vg_UserMsg, "The only supported clone() uses are:\n");
+      VG_(message)(Vg_UserMsg, " - via a threads library (LinuxThreads or NPTL)\n");
+      VG_(message)(Vg_UserMsg, " - via the implementation of fork or vfork\n");
+      VG_(message)(Vg_UserMsg, " - for the Quadrics Elan3 user-space driver\n");
       VG_(unimplemented)
          ("Valgrind does not support general clone().");
    }

Modified: trunk/coregrind/m_syswrap/syswrap-arm64-linux.c
==============================================================================
--- trunk/coregrind/m_syswrap/syswrap-arm64-linux.c (original)
+++ trunk/coregrind/m_syswrap/syswrap-arm64-linux.c Sat Nov 29 17:50:10 2014
@@ -601,13 +601,12 @@
 
    default:
       /* should we just ENOSYS? */
-      VG_(message)(Vg_UserMsg, "");
-      VG_(message)(Vg_UserMsg, "Unsupported clone() flags: 0x%lx", ARG1);
-      VG_(message)(Vg_UserMsg, "");
-      VG_(message)(Vg_UserMsg, "The only supported clone() uses are:");
-      VG_(message)(Vg_UserMsg, " - via a threads library (LinuxThreads or NPTL)");
-      VG_(message)(Vg_UserMsg, " - via the implementation of fork or vfork");
-      VG_(message)(Vg_UserMsg, " - for the Quadrics Elan3 user-space driver");
+      VG_(message)(Vg_UserMsg, "Unsupported clone() flags: 0x%lx\n", ARG1);
+      VG_(message)(Vg_UserMsg, "\n");
+      VG_(message)(Vg_UserMsg, "The only supported clone() uses are:\n");
+      VG_(message)(Vg_UserMsg, " - via a threads library (LinuxThreads or NPTL)\n");
+      VG_(message)(Vg_UserMsg, " - via the implementation of fork or vfork\n");
+      VG_(message)(Vg_UserMsg, " - for the Quadrics Elan3 user-space driver\n");
       VG_(unimplemented)
          ("Valgrind does not support general clone().");
    }

Modified: trunk/coregrind/m_syswrap/syswrap-darwin.c
==============================================================================
--- trunk/coregrind/m_syswrap/syswrap-darwin.c (original)
+++ trunk/coregrind/m_syswrap/syswrap-darwin.c Sat Nov 29 17:50:10 2014
@@ -647,22 +647,23 @@
    OpenPort *i;
    
    VG_(message)(Vg_UserMsg, 
-                "MACH PORTS: %d open at exit.", allocated_port_count);
+                "MACH PORTS: %d open at exit.\n", allocated_port_count);
 
    for (i = allocated_ports; i; i = i->next) {
       if (i->name) {
-         VG_(message)(Vg_UserMsg, "Open Mach port 0x%x: %s", i->port, i->name);
+         VG_(message)(Vg_UserMsg, "Open Mach port 0x%x: %s\n", i->port,
+                      i->name);
       } else {
-         VG_(message)(Vg_UserMsg, "Open Mach port 0x%x", i->port);
+         VG_(message)(Vg_UserMsg, "Open Mach port 0x%x\n", i->port);
       }
 
       if (i->where) {
          VG_(pp_ExeContext)(i->where);
-         VG_(message)(Vg_UserMsg, "");
+         VG_(message)(Vg_UserMsg, "\n");
       }
    }
 
-   VG_(message)(Vg_UserMsg, "");
+   VG_(message)(Vg_UserMsg, "\n");
 }
 
 
@@ -3997,7 +3998,7 @@
       break;
 
    default:
-      VG_(message)(Vg_UserMsg, "UNKNOWN auditon cmd %ld", ARG1);
+      VG_(message)(Vg_UserMsg, "UNKNOWN auditon cmd %ld\n", ARG1);
       break;
    }
 }

Modified: trunk/coregrind/m_syswrap/syswrap-s390x-linux.c
==============================================================================
--- trunk/coregrind/m_syswrap/syswrap-s390x-linux.c (original)
+++ trunk/coregrind/m_syswrap/syswrap-s390x-linux.c Sat Nov 29 17:50:10 2014
@@ -525,11 +525,11 @@
 
    default:
       /* should we just ENOSYS? */
-      VG_(message)(Vg_UserMsg, "Unsupported clone() flags: 0x%lx", ARG2);
-      VG_(message)(Vg_UserMsg, "");
-      VG_(message)(Vg_UserMsg, "The only supported clone() uses are:");
-      VG_(message)(Vg_UserMsg, " - via a threads library (NPTL)");
-      VG_(message)(Vg_UserMsg, " - via the implementation of fork or vfork");
+      VG_(message)(Vg_UserMsg, "Unsupported clone() flags: 0x%lx\n", ARG2);
+      VG_(message)(Vg_UserMsg, "\n");
+      VG_(message)(Vg_UserMsg, "The only supported clone() uses are:\n");
+      VG_(message)(Vg_UserMsg, " - via a threads library (NPTL)\n");
+      VG_(message)(Vg_UserMsg, " - via the implementation of fork or vfork\n");
       VG_(unimplemented)
          ("Valgrind does not support general clone().");
    }

Modified: trunk/drd/drd_semaphore.c
==============================================================================
--- trunk/drd/drd_semaphore.c (original)
+++ trunk/drd/drd_semaphore.c Sat Nov 29 17:50:10 2014
@@ -55,7 +55,7 @@
    tl_assert(sg);
    n = VG_(addToXA)(p->last_sem_post_seg, &sg);
 #if 0
-   VG_(message)(Vg_DebugMsg, "0x%lx push: added at position %ld/%ld",
+   VG_(message)(Vg_DebugMsg, "0x%lx push: added at position %ld/%ld\n",
                 p->a1, n, VG_(sizeXA)(p->last_sem_post_seg));
 #endif
    tl_assert(*(Segment**)VG_(indexXA)(p->last_sem_post_seg, n) == sg);
@@ -69,7 +69,7 @@
 
    sz = VG_(sizeXA)(p->last_sem_post_seg);
 #if 0
-   VG_(message)(Vg_DebugMsg, "0x%lx pop:  removed from position %ld/%ld",
+   VG_(message)(Vg_DebugMsg, "0x%lx pop:  removed from position %ld/%ld\n",
                 p->a1, sz - 1, sz);
 #endif
    sg = 0;