[Valgrind-developers] a question about maybe_merge_segments

[Florian K. <fl...@ei...>]

Greetings:

When considering whether two SkFile segments can be merged (in
maybe_merge_nsegments), the segment name is not taken into
consideration. I'm wondering whether it should be. Segment names are, in
general, user-visible via the following chain:
VG_(get_am_filename) <-- VG_(get_objname) <-- VG_(describe_IP)
That could lead to an incorrect segment name being reported for a given
address:  Suppose an address X which is (originally) inside a segment
named FOO. Should FOO get merged into a segment named BAR then
VG_(am_get_filename)(X) would return BAR which is wrong (and maybe
confusing).

Or does equality of the "dev" and "ino" fields imply equality of the
segment names? If so, checking the name would of course be redundant.

   Florian