|
From: Mark W. <mj...@re...> - 2014-09-18 12:27:06
|
On Sun, 2014-09-07 at 14:32 +0200, Philippe Waroquiers wrote: > On Sun, 2014-09-07 at 14:25 +0200, Mark Wielaard wrote: > > On Sun, Sep 07, 2014 at 01:13:28PM +0200, Philippe Waroquiers wrote: > > > The stabs reader is disabled since 3.9.0 (as it was not converted > > > to use the new image/di-server). > > > We however still compile the (I think) broken code. > > > Maybe we should just remove it ? > > > > Haha. I was a little suspecious I couldn't find any tests for the > > code. So checked and double checked this was the right definition > > to use for the stabs symbol nlist entry struct. Now I know the real > > reason why everything seemed to go fine :) > > > > So yeah, lets just remove the code before others accidentially > > spend any more time on it. > Julian also thinks the code can be removed, but better done after > the release, to avoid any kind of build/whatever problems. There was indeed a non-trivial amount of code that tried to do something STABS (and then actually didn't do anything). Since we are after the release now finally tried to clean this up and removed the dead code. See valgrind svn r14550. Please yell and scream if I accidentally broke something. Cheers, Mark |