|
From: <sv...@va...> - 2014-09-15 20:18:50
|
Author: florian
Date: Mon Sep 15 20:18:39 2014
New Revision: 14540
Log:
Remove a comment that is no longer valid. The real reason we (now)
don't provide strtoll etc is that we don't need the flexibility and
are too lazy to implement the general case :) But that does not
warrant a comment in the code.
Modified:
trunk/include/pub_tool_libcbase.h
Modified: trunk/include/pub_tool_libcbase.h
==============================================================================
--- trunk/include/pub_tool_libcbase.h (original)
+++ trunk/include/pub_tool_libcbase.h Mon Sep 15 20:18:39 2014
@@ -54,11 +54,6 @@
// is set to the start of the string. None of them test that the number
// fits into 64 bits.
//
-// Nb: if you're wondering why we don't just have a single VG_(strtoll) which
-// takes a base, it's because I wanted it to assert if it was given a bogus
-// base (the standard glibc one sets 'errno' in this case). But
-// m_libcbase.c doesn't import any code, not even vg_assert. --njn
-//
// Nb: we also don't provide VG_(atoll*); these functions are worse than
// useless because they don't do any error checking and so accept malformed
// numbers and non-numbers -- eg. "123xyz" gives 123, and "foo" gives 0!
|