Re: [Valgrind-developers] Fallout from BEAM run

[Philippe W. <phi...@sk...>]

On Mon, 2013-09-30 at 22:25 +0200, Florian Krohm wrote:
> On 09/30/2013 09:46 PM, Philippe Waroquiers wrote:
> 
> >> "coregrind/m_oset.c", line 931: Statement is unreachable
> >>
> >> COMMENT: This one was found by the EDG frontend. It produced loads of
> >>          messages so I did not spot this in earlier runs.
> >>          Not sure.. perhaps this code was meant to be reached with a
> >>          missing break somewhere?
> > This I do not understand.
> > On the last svn trunk, line 931 is there:
> 
> Sorry, my mistake. Should have said: line 913, not line 931.

Took a quick look at it, the dead code looks strange.

There is no test of VG_(OSetGen_ResetIterAt) in unit_oset.c.
I will take a look at adding a test for VG_(OSetGen_ResetIterAt).

Maybe that will show a bug in this area.

Philippe