|
From: <sv...@va...> - 2013-01-25 09:46:51
|
sewardj 2013-01-25 09:46:43 +0000 (Fri, 25 Jan 2013)
New Revision: 2661
Log:
Annotate ARMNImm_to_Imm64 with fallthrough markers following
verification against the table in host_arm_defs.h, "Neon Immediate
operand". A particularly nasty piece of code.
Modified files:
trunk/priv/host_arm_defs.c
Modified: trunk/priv/host_arm_defs.c (+5 -3)
===================================================================
--- trunk/priv/host_arm_defs.c 2013-01-25 09:03:32 +00:00 (rev 2660)
+++ trunk/priv/host_arm_defs.c 2013-01-25 09:46:43 +00:00 (rev 2661)
@@ -556,11 +556,11 @@
ULong y, x = imm->imm8;
switch (imm->type) {
case 3:
- x = x << 8;
+ x = x << 8; /* fallthrough */
case 2:
- x = x << 8;
+ x = x << 8; /* fallthrough */
case 1:
- x = x << 8;
+ x = x << 8; /* fallthrough */
case 0:
return (x << 32) | x;
case 5:
@@ -569,11 +569,13 @@
x = x << 8;
else
x = (x << 8) | x;
+ /* fallthrough */
case 4:
x = (x << 16) | x;
return (x << 32) | x;
case 8:
x = (x << 8) | 0xFF;
+ /* fallthrough */
case 7:
x = (x << 8) | 0xFF;
return (x << 32) | x;
|